[PATCH] D28891: add support for Cavium ThunderX ARM64 processors
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 19 04:19:24 PST 2017
rengolin added reviewers: t.p.northover, rovka, kristof.beyls, jgreenhalgh.
rengolin added a subscriber: llvm-commits.
rengolin added a comment.
Few inline comments. I'm adding a few people to review plus copying llvm-commits.
Next time, remember that if you don't do that, people don't see it. :)
Comment at: lib/Support/TargetParser.cpp:451
+ if (Extensions & AArch64::AEK_LSE)
Please, add unit test for this and the new cores.
Comment at: lib/Target/AArch64/AArch64.td:308
Isn't LSE 8.1? Do X and XT88 only implement 8.0 + LSE?
More information about the llvm-commits