[PATCH] D28805: [GlobalISel] Pointers are legal operands for G_SELECT on AArch64

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 04:02:36 PST 2017

dsanders added a comment.

This looks good to me but I don't feel I have sufficiently complete knowledge of AArch64 to be approving codegen changes yet. It would be good to get an LGTM from one of the other reviewers before committing.

> I'm not sure if we could tablegen the functionality I'm touching in this patch.

The current code looks like it will fit in to the tablegen definitions I've been sketching.

> Even if we did, I think that manually fixing this is helpful, as it results in other issues being hidden less while we don't have tablegen for this.

I agree. It will be a while before the tablegen pass is complete enough to handle the things it needs to and there's no need to block this fix on that work.


More information about the llvm-commits mailing list