[PATCH] D28894: [Support] Use O_CLOEXEC only when declared

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 01:56:51 PST 2017

labath added a comment.

In the original version my patch (https://reviews.llvm.org/D28854) I had fallback code which sets the FD_CLOEXEC flag using fcntl(2). What do you think about using that? It's a bit racy, but it's better than nothing.

I intend to start using these function from lldb, so if anyone will use lldb on the old systems, he'll get descriptor leakage there.



More information about the llvm-commits mailing list