Fwd: NDS32 V3 backend
Shiva Chen via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 19 01:05:57 PST 2017
Hi Tobias and Joerg,
To my understanding, the test cases in test/CodeGen could run by lit
until InstPrinter have been implement.
So, should I add the CodeGen test cases in the
[NDS32 17/22] add NDS32 Instruction Printer patch ?
Or before the InstPrinter have been implement, there're still other
testcase I should add ?
Thanks for your time to look at the patches.
2017-01-15 4:54 GMT+08:00 Joerg Sonnenberger <joerg at bec.de>:
> On Fri, Jan 13, 2017 at 05:01:22PM +0100, Tobias Grosser via llvm-commits wrote:
>> I had a quick look at your patches. It seems you do not have any test
>> cases (except in the last patch). If this is true, I am afraid this will
>> be one of the first things reviewers will miss.
> To expand on this slightly: ideally, each new phase of the backend
> should have patches that test that the newly added part works. This
> makes it useful to hook up MC ASAP so that you can test instruction
> patterns etc.
More information about the llvm-commits