[PATCH] D28291: [ARM] Create SubtargetFeatures from build attributes

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: llvm/trunk/include/llvm/Object/ObjectFile.h:270
   virtual SubtargetFeatures getFeatures() const = 0;
+  virtual SubtargetFeatures getMIPSFeatures() const { return SubtargetFeatures(); }
+  virtual SubtargetFeatures getARMFeatures() const { return SubtargetFeatures(); }
----------------
Possibly should just be an internal helper routine and not a virtual alongside the normal API?


Repository:
  rL LLVM

https://reviews.llvm.org/D28291