[PATCH] D28856: [CMake] Teach CMake how to generate `LibraryDependencies.inc`
Chris Bieneman via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 18 12:32:39 PST 2017
I think the LLVM-Config issue is more complicated than what you've provided. First, `is_llvm_target_library` is completely broken. It is trying to match component names against library names, which never match because the later is prefixed with LLVM. It also is an incomplete listing of the target libraries. The only reason this isn't exploding is because none of our components ever list specific target dependencies in situations where they would be missing.
Also, I think that adding target libraries that are configured out is a bad idea, so we should fix that functionality, not get rid of it.
I think a more appropriate patch to the LLVM-Config bugs would be something like this:
Please test that with your changes, and if it works I'll commit it.
> On Jan 18, 2017, at 10:35 AM, bryant via Phabricator <reviews at reviews.llvm.org> wrote:
> bryant added a dependency: D28855: [CMake] Copy per-component `required_libraries` into `LINK_COMPONENTS`. NFC..
> bryant added a comment.
> Depends on https://reviews.llvm.org/D28855.
> rL LLVM
More information about the llvm-commits