[PATCH] D21839: PowerPC: Use shouldAssumeDSOLocal in classifyGlobalReference
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 18 11:53:25 PST 2017
Hal Finkel via Phabricator <reviews at reviews.llvm.org> writes:
> hfinkel added a comment.
> So you can't interpose weak symbols on PPC?
Not if the symbol is defined in the main executable. It is always the
first one in the dynamic list search order.
> Comment at: lib/Target/TargetMachine.cpp:151
> + Triple::ArchType Arch = TT.getArch();
> + bool IsPPC =
> + Arch == Triple::ppc || Arch == Triple::ppc64 || Arch == Triple::ppc64le;
> We should add a comment here that PPC does not use copy relocations.
Will do. I am also rebasing the patch.
More information about the llvm-commits