[PATCH] D28855: [CMake] Copy per-component `required_libraries` into `LINK_COMPONENTS`. NFC.

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 11:49:39 PST 2017

mgorny added inline comments.

Comment at: cmake/modules/LLVM-Config.cmake:204
-          message(FATAL_ERROR "Library `${c}' not found in list of llvm libraries.")
-        endif()
       else( lib_idx LESS 0 )
To be honest, I'm not convinced about this. Do I understand correctly that this code means to ensure case-insensitive mapping of libraries to their correct names? If it's not possible to do that reliably, I'd rather not do that at all and instead require people to write out correct names.

For a start, do you think it'd be possible to record all hits of this branch and check them later on? I'm thinking of checking any possible mismatches at the end of CMake, so if the canonicalization can't work, developers get to fix their case anyway.

Comment at: lib/Analysis/CMakeLists.txt:95
+    Object
I would normally say you left a stray empty line here but I don't expect you to fix all those files ;-).



More information about the llvm-commits mailing list