[PATCH] D28420: [lit] Limit parallelism of sanitizer tests on Darwin

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added inline comments.


================
Comment at: utils/lit/lit/run.py:182
+        pg = test.config.parallelism_group
+        if callable(pg): pg = pg(test)
+
----------------
kubabrecka wrote:
> MatzeB wrote:
> > kubabrecka wrote:
> > > MatzeB wrote:
> > > > Supporting callbacks here feels overengineered, but if you have to...
> > > I tried really hard not to use a callback, but unfortunately for compiler-rt unittests (gtest-style), we can't just set `config.parallelism_group` at lit launch time -- we only know the architecture after test discovery.  I'm open to suggestions if you can think of a better way of handling this.
> > I don't understand exactly what is happening with the gtests here. Do you expect unittests for architectures other than `config.host_os` being present?
> > I wouldn't expect us to have infrastructure here to even run tests for targets other than the host...
> We have i386 and x86_64 unittests.  Finding which tests are 64-bit can only be done after test discovery.
Ah. Well, I don't have any better suggestion than the callback right now.


https://reviews.llvm.org/D28420