[PATCH] D28693: [InlineCost] Use TTI to check if GEP is free.

Chad Rosier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 11:02:18 PST 2017

mcrosier added a comment.

LGTM, but this should be further reviewed by someone with more familiarity of the inliner cost model.

Comment at: test/Transforms/Inline/gep-cost.ll:1
+; RUN: opt -inline < %s -S -debug-only=inline-cost 2>&1 | FileCheck %s
I apologize for my lack of understanding.  Assuming this isn't obvious to someone more familiar with the inliner cost model, would you mind adding a few comments to this test case explaining exactly what you're testing?

I diffed the output from this test with and without your change and the only cost that was changed was for inner1.  Thus, I'm trying to understand the significance of inner2.



More information about the llvm-commits mailing list