[PATCH] D28420: [lit] Limit parallelism of sanitizer tests on Darwin

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 10:49:04 PST 2017

kubabrecka added a comment.

Thanks for reviewing this!  I'll submit another patch.

Comment at: utils/lit/lit/run.py:182
+        pg = test.config.parallelism_group
+        if callable(pg): pg = pg(test)
MatzeB wrote:
> Supporting callbacks here feels overengineered, but if you have to...
I tried really hard not to use a callback, but unfortunately for compiler-rt unittests (gtest-style), we can't just set `config.parallelism_group` at lit launch time -- we only know the architecture after test discovery.  I'm open to suggestions if you can think of a better way of handling this.


More information about the llvm-commits mailing list