[PATCH] D28751: [ThinLTO] Add a recursive step in Metadata lazy-loading

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 10:48:20 PST 2017

mehdi_amini added a comment.

In https://reviews.llvm.org/D28751#648142, @tejohnson wrote:

> Nice improvement - is this related to the regression you saw in your measurements on the effectiveness of lazy loading metadata? A few comments/suggestions below.

Yes, it recovers this and goes beyond.

> Do we have a test case that exposes this issue? If not, it would be good to add

Added! Thanks it was a good idea as it shown that the patch was wrong (I was creating a temp for the operand about to be lazy-loaded instead of the parent).



More information about the llvm-commits mailing list