[PATCH] D28861: [Assembler] Improve error when unable to evaluate expression.

Jim Grosbach via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 10:19:08 PST 2017

grosbach added a comment.

This LGTM in general. I agree w/ Renato that CHECK-DAG is a bit unexpected. Can you elaborate on why that's better than plain CHECK?

I've long wanted better plumbing of location info through the asm stuff. This is a nice step in that direction. Thank you for working on it! Do you intend to continue on with threading this through the various places that create MCExprs in the AsmParser?



More information about the llvm-commits mailing list