[PATCH] D28626: RFC: Generalize inverted gc dependencies

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 09:50:36 PST 2017


pcc added a comment.

The design of this feature looks good to me, thanks.



================
Comment at: lld/ELF/InputFiles.cpp:322
+        (!Base || !isa<InputSection<ELFT>>(Base)))
+      error("SHF_ASSOCIATED only supported with regular sections " +
+            toString(Base));
----------------
I think it's fine to have this restriction, but aren't we still crashing on associated sections with relocations referring to merge sections?


https://reviews.llvm.org/D28626





More information about the llvm-commits mailing list