[PATCH] D28854: raw_fd_ostream: Make file handles non-inheritable by default

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 06:20:55 PST 2017

Pavel Labath via Phabricator <reviews at reviews.llvm.org> writes:

> labath created this revision.
> Herald added a subscriber: mgorny.
> This makes the file descriptors on unix platform non-inheritable by default
> (O_CLOEXEC). I have also added a file open flag F_Inheritable to override this
> behavior if necessary.

Does anything need it right now or do you plan to use it soon? If not I
would suggest leaving it out.

> If the platform supports O_CLOEXEC flag, we will use it
> to set the descriptor flag during open(2). If the flag is not available, we will
> revert to the (racy) fcntl(2) call.

Do you know which OSs don't have O_CLOEXEC?


More information about the llvm-commits mailing list