[PATCH] D28549: Global DCE performance improvement

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 02:02:06 PST 2017

serge-sans-paille added inline comments.

Comment at: include/llvm/Transforms/IPO/GlobalDCE.h:41
+  // Constant -> Globals that use this global cache.
+  std::unordered_map<Constant *, SmallPtrSet<GlobalValue *, 8>>
+      ConstantDependenciesCache;
mehdi_amini wrote:
> majnemer wrote:
> > DenseMap?
> DenseMap with a `SmallPtrSet`? 
I've kept the original Moving to a std::unordered_multimap for GVDEpendencies, not sure about what you expect for the ConstantDependenciesCache. What's the pro/con of using a DenseMap?



More information about the llvm-commits mailing list