[PATCH] D28676: Makes incremental dominator calculation in Loop Unroll pass

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 21:51:08 PST 2017

sepavloff abandoned this revision.
sepavloff added a comment.

@mkuper - thank you for review and clarifications.

@efriedma - loop unrolling is a hot topic, things are changing too fast here, I somehow overlooked your patch, sorry. I agree, your treatment in LoopUnroll.cpp is more general, and don't think adding incremental update to LoopUnrollPeel.cpp will be a problem. The only advantage of my patch is testing, you are not going to add option `unroll-peel-verify-domtree`, right? :) But this is not related to loop unrolling, and probably deserves a separate patch. I think we should have possibility to provide verification flags to all tests in a test suite without need to alter the test sources. Other transformations may also gain from domtree and loop verification turned on.


More information about the llvm-commits mailing list