[PATCH] D28170: [LICM] When promoting scalars, allow inserting stores to thread-local allocas

Xin Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 21:39:28 PST 2017


trentxintong added inline comments.


================
Comment at: llvm/trunk/test/Transforms/LICM/promote-tls.ll:67
+  %old = load i32, i32* %addr, align 4
+  ; deliberate impossible to analyze branch
+  %guard = load atomic i8*, i8** @p monotonic, align 8
----------------
Any particular reason why this can not be br i1 undef, label %a, label %b ? Understandably, this can be simplified by SimplifyCFG or SCCP. but we are only running LICM here ?


Repository:
  rL LLVM

https://reviews.llvm.org/D28170





More information about the llvm-commits mailing list