[PATCH] D28794: [NVPTX] Upgrade NVVM intrinsics in InstCombineCalls.

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 16:51:47 PST 2017

majnemer added inline comments.

Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1412
+    SimplifyAction() {}
jlebar wrote:
> majnemer wrote:
> > = default?
> Is there a reason to prefer that over this syntax?  This is fewer chars, which is why I chose to do it this way.
The constructor of SimplifyAction could be trivial because the compiler can see what's going on. This would not be so with a user defined constructor.


More information about the llvm-commits mailing list