[PATCH] D28596: [compiler-rt] General definition for weak functions.

Mike Aizatsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 16:06:25 PST 2017

aizatsky requested changes to this revision.
aizatsky added a comment.
This revision now requires changes to proceed.

I don't like that we introduce macros making function definition ugly and opaque. All this to implement one platform hacks. I would prefer to have current version cleaned up to eliminate ifdefs. Something like:

  const char *__ubsan_default_options() { return ""; }

Is such clenup possible? What properties does proposed solution have that cleanup one doesn't?


More information about the llvm-commits mailing list