[PATCH] D28715: Raise the PDB Hash Map out of the NameMap class

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 14:47:16 PST 2017

zturner added inline comments.

Comment at: llvm/lib/DebugInfo/PDB/Raw/HashTable.cpp:189
+    return;
+  uint32_t NewCapacity = capacity() * 2;
majnemer wrote:
> Should we assert that `NewCapacity` is bigger than `capacity()`?
Forgot about this, I'm using your suggestion of `std::max` from the previous comment, will upload a fix and some other minor cleanups shortly.


More information about the llvm-commits mailing list