[PATCH] D28558: [CMake] Ignore hidden/metadata files when adding lit check-* testsuites

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 14:06:55 PST 2017

mgorny added inline comments.

Comment at: cmake/modules/AddLLVM.cmake:1218
       string(FIND ${lit_suite} Output is_output)
-      if (NOT (is_inputs EQUAL -1 AND is_output EQUAL -1))
+      string(COMPARE EQUAL ${lit_suite} "^[.].*" is_hidden)
+      if (NOT (is_inputs EQUAL -1 AND is_output EQUAL -1 AND is_hidden EQUAL -1))
Any reason not to just use literal `${lit_suite} MATCHES "^[.]"` in if?

The Inputs/Output check could be made nicer too, I guess; but only if you want to play with them. I'm pretty sure the current version would match `Inputs` somewhere in path or filename.


More information about the llvm-commits mailing list