[PATCH] D28086: [CMake] Subsume LLVMBuild.txt. Disabled by default.
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 17 13:55:25 PST 2017
beanz added a comment.
@bryant and I spoke over IRC in a PM, for posterity I'll recap here.
@chapuni I also thought using `LINK_LIBS` would make sense, but that is actually more complicated because we have special "magic" values that work for components like the "Native" target that we still need to support. If we want to get rid of the notion of special-purpose components I think we should consider that separately.
I've suggested that this patch be split into two patches.
One that adds missing dependencies by adding `LINK_COMPONENTS` as named arguments to the add_llvm_* calls, which can be done always with no conditionals, and should be NFC. This patch will result in filling in the missing gaps where our CMake currently does't express the full dependency tree.
Then a second patch which adds support for generating the LinkDependencies.inc file from CMake's dependency information.
There may be a few small CMake issues that pop up and need to be addressed between the first and second patch, but we can work through that as they come up.
More information about the llvm-commits