[PATCH] D28600: [compiler-rt] [Sanitizer Coverage] Use interception to access to sanitizer coverage's strong functions defined in the main executable (for MD on Windows.)

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 13:14:27 PST 2017


rnk added inline comments.


================
Comment at: lib/asan/asan_win_coverage_interception.cc:55
+  // non-defult implementations are provided.
+  INTERCEPT_WEAK(__sanitizer_cov_trace_cmp)
+  INTERCEPT_WEAK(__sanitizer_cov_trace_cmp1)
----------------
I think we may wish to have a .def file that includes the full list of weak sanitizer coverage callbacks to avoid this repetition.


Repository:
  rL LLVM

https://reviews.llvm.org/D28600





More information about the llvm-commits mailing list