[PATCH] D28468: [X86] Fix for bugzilla 31576 - add support for "data32" instruction prefix

Marina Yatsina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 11:50:41 PST 2017


myatsina added a comment.

In https://reviews.llvm.org/D28468#648538, @niravd wrote:

> In https://reviews.llvm.org/D28468#648513, @myatsina wrote:
>
> > Can you see the tests? I've added comments next to them.
> >  Do this tests capture what you meant?
>
>
> Yes.
>
> But I thought you also had one using llvm-objdump so we also test the object->instruction disassembly path.


The llvm-objdump tests are the newly added data-prefix16.s, data-prefix32.s, data-prefix64.s which have the following run line:

RUN: llvm-mc -triple<triple> -filetype=obj %s -o - | llvm-objdump -triple <triple> -d - | FileCheck %s
======================================================================================================

I will add to those tests the "data16"/"data32" disassembly once I tweak the asm printer.


Repository:
  rL LLVM

https://reviews.llvm.org/D28468





More information about the llvm-commits mailing list