[PATCH] D28549: Global DCE performance improvement

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: include/llvm/Transforms/IPO/GlobalDCE.h:41
+  // Constant -> Globals that use this global cache.
+  std::unordered_map<Constant *, SmallPtrSet<GlobalValue *, 8>>
+      ConstantDependenciesCache;
----------------
majnemer wrote:
> DenseMap?
DenseMap with a `SmallPtrSet`? 


================
Comment at: include/llvm/Transforms/IPO/GlobalDCE.h:44
+
+  // Comdat -> Globals in that Comdat section.
   std::unordered_multimap<Comdat *, GlobalValue *> ComdatMembers;
----------------
Doxygen like-prefix.


================
Comment at: lib/Transforms/IPO/GlobalDCE.cpp:81
 
+// Compute the set of GlobalValue that depends from V
+// The recursion stops as soon as a GlobalValue is met.
----------------
End sentence with a dot.


================
Comment at: lib/Transforms/IPO/GlobalDCE.cpp:82
+// Compute the set of GlobalValue that depends from V
+// The recursion stops as soon as a GlobalValue is met.
+void GlobalDCEPass::ComputeDependencies(Value *V,
----------------
Doxygen-like prefix.


Repository:
  rL LLVM

https://reviews.llvm.org/D28549