[PATCH] D28724: Use getLoopLatch in place of isLoopSimplifyForm

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 10:32:56 PST 2017

MatzeB added a comment.

In https://reviews.llvm.org/D28724#648397, @MatzeB wrote:

> Why was this implemented as a unittest? Wouldn't this work just as good by inserting some debug prints and then using lit+opt+FileCheck to test?

Admittedly the same is true for many of the other tests in unittests/Analysis. Most of the times I just don't see the benefits of using unittests over lit+FileCheck, they are usually a lot harder to understand and debug.



More information about the llvm-commits mailing list