[PATCH] D28797: [LangRef] Make @llvm.sqrt(x) return undef, rather than have UB, for negative x.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 08:44:31 PST 2017


sanjoy accepted this revision.
sanjoy added a comment.

This LGTM; especially since `llvm::isSafeToSpeculativelyExecute` already returns true for calls to `llvm.sqrt` (so if some place in LLVM thinks `llvm.sqrt` may have UB, we're already miscompiling).


https://reviews.llvm.org/D28797





More information about the llvm-commits mailing list