[PATCH] D28697: [AArch64] Generate literals by the little end

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 08:18:17 PST 2017

evandro added a comment.

Hi, @rengolin .

> Isn't this specific to A57 (as in https://reviews.llvm.org/D28698)? Do you have any data that this will perform equally or better on the other AArch64 cores, too?

https://reviews.llvm.org/D28698 needs this change, but I think that it makes more sense to have both patches separated.

Unfortunately, I don't have access to other targets.  On A57, which may fuse the resulting instr sequence, benefits from this change.  On the only other target that I have access to, the M1, which doesn't fuse literals generation, this change was a wash.

> Also, the commit message could be improved by mentioning why "ARM seems to prefer that long literals be formed from their little end.", ie. a reference to the A57 manual.




More information about the llvm-commits mailing list