[PATCH] D28079: [GlobalISel] Add support for indirectbr

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 05:51:31 PST 2017


kristof.beyls updated this revision to Diff 84662.
kristof.beyls added a comment.

Updating patch to ToT.
I believe this is ready to be committed, but am waiting for an LGTM from someone.

Regarding adding a test for the MIR->assembly path: I indeed hit https://llvm.org/bugs/show_bug.cgi?id=30324 when trying to do so.
I've got the least-hacky patch I could come up with to fix that up for review at https://reviews.llvm.org/D28513.
I don't think it's worthwhile to block indirectbr support on that though: we already lack MIR->assembly tests for all the other instructions already handled by GlobalISel, so can just add that test for indirectbr when we add those tests for all the other instructions too.


https://reviews.llvm.org/D28079

Files:
  include/llvm/CodeGen/GlobalISel/IRTranslator.h
  include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
  include/llvm/Target/GenericOpcodes.td
  include/llvm/Target/TargetOpcodes.def
  lib/CodeGen/GlobalISel/IRTranslator.cpp
  lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
  lib/Target/AArch64/AArch64InstructionSelector.cpp
  lib/Target/AArch64/AArch64LegalizerInfo.cpp
  test/CodeGen/AArch64/GlobalISel/arm64-instructionselect.mir
  test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28079.84662.patch
Type: text/x-patch
Size: 7915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170117/135c5c03/attachment.bin>


More information about the llvm-commits mailing list