[PATCH] D28684: [Support/Compression] - Change zlib API to return Error instead of custom status.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 05:15:24 PST 2017

Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:

> George Rimar <grimar at accesssoftek.com> writes:
>> I see now, thanks. Checked state of Error object 
>> verified only when LLVM_ENABLE_ABI_BREAKING_CHECKS defined. It was not for me.
>> That is why code worked for me during debugging.
> That should be enable by default on any ASSERTS build.
> But I don't see code that handles error more strictly than success. I
> will write a quick test.

Never mind, I need a coffee.

    if (!getChecked() || getPtr()) {

is true if we have an Error, so the description was correct. Looking at
the patch now.


More information about the llvm-commits mailing list