[PATCH] D28675: [DAGCombine] require UnsafeFPMath for re-association of addition
Nicolai Hähnle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 17 03:04:24 PST 2017
nhaehnle updated this revision to Diff 84647.
nhaehnle added a comment.
1. Take individual UnsafeAlgebra flags into account.
There's a question of whether the flag should be required on both of the involved nodes, or if having it one of them is sufficient. I opted for requiring it on both of them, to prevent unsafe flags from leaking out of where they were originally added.
2. Simplify the outside condition; as Matt pointed out, the guard of (AllowFusion || HasFMAD) is no longer required, because each of the contained blocks has a check that is at least as strict.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 25927 bytes
Desc: not available
More information about the llvm-commits