[PATCH] D28675: [DAGCombine] require UnsafeFPMath for re-association of addition

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle updated this revision to Diff 84647.
nhaehnle added a comment.

1. Take individual UnsafeAlgebra flags into account.

  There's a question of whether the flag should be required on both of the involved nodes, or if having it one of them is sufficient. I opted for requiring it on both of them, to prevent unsafe flags from leaking out of where they were originally added.

2. Simplify the outside condition; as Matt pointed out, the guard of (AllowFusion || HasFMAD) is no longer required, because each of the contained blocks has a check that is at least as strict.


https://reviews.llvm.org/D28675

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/AMDGPU/fma-combine.ll
  test/CodeGen/AMDGPU/mad-combine.ll
  test/CodeGen/NVPTX/fma-assoc.ll
  test/CodeGen/PowerPC/fma-assoc.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28675.84647.patch
Type: text/x-patch
Size: 25927 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170117/184612f0/attachment-0001.bin>