[PATCH] D28484: SimplifyLibCalls: Replace more unary libcalls with intrinsics

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 16:53:42 PST 2017

davide added a comment.

In https://reviews.llvm.org/D28484#647688, @arsenm wrote:

> In https://reviews.llvm.org/D28484#640523, @efriedma wrote:
> > For anyone else following along with a copy of IEEE 754, this is the roundToIntegral* family of functions.
> >
> > Aren't llvm.rint() and llvm.nearbyint() precisely equivalent?  We should probably get rid of llvm.rint()... (we can add it back once we actually start modeling FP exceptions).
> Should I drop rint handling here or keep it until later when it's removed?

I'd say keep it until we agree we're going to remove it.


More information about the llvm-commits mailing list