[lld] r291944 - Don't add DT_INIT/DT_FINI for undef and shared symbols.

[Sean Silva via llvm-commits]

On Mon, Jan 16, 2017 at 7:11 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Sean Silva <chisophugis at gmail.com> writes:
>
> >>  template <class ELFT>
> >> +SymbolBody *SymbolTable<ELFT>::findDefined(StringRef Name) {
> >>
> >
> > Can you make this name more specific so that it captures the intent of
> what
> > this function does better?
>
> I agree that "defined" is a bit overloaded, but not think of anything
> better ("local" is also overloaded). Maybe findInCurrentDSO?
>

I like findInCurrentDSO (maybe "output DSO" instead of "current DSO"?).

-- Sean Silva


>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170116/acb402de/attachment.html>