[PATCH] D28694: Hexagon-specific loop idiom recognition
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 16 09:49:19 PST 2017
hfinkel added inline comments.
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:320
+ addExtensionsToPM(EP_LoopIdiom, MPM);
MPM.add(createLoopIdiomPass()); // Recognize idioms like memset.
> This extension point could get its own separate patch.
> It seems very targeted, if the only point is to have TargetSpecific loop idiom recognition, then why aren't some TTI implemented and used in LoopIdiomPass?
I thought about suggesting this, but didn't because:
a. It is not clear what from the existing loop idiom recognition pass could be reused
b. The target-specific logic might want access to other analyses, and that would be awkward if it is just a TTI callback.
What do you think?
More information about the llvm-commits