[PATCH] D28313: Change which input sections we concatenate

[Rafael Avila de Espindola via llvm-commits]

Ed Maste <emaste at freebsd.org> writes:

> On 14 January 2017 at 22:39, Rafael Avila de Espindola
> <rafael.espindola at gmail.com> wrote:
>> Ed Maste <emaste at freebsd.org> writes:
>>>
>>> It turns out this is PR31221 again -- i.e., LLD went back to emitting
>>> a zeroed GOT, and FreeBSD PR214972 (to avoid relying on a
>>> pre-populated GOT) is not yet addressed.
>>
>> Was it ever really "fixed"? Reading r288451 I am pretty sure it only
>> changed the output for !RelTy::IsRela.
>
> Interesting, it's possible that either I had the wrong "fixed"
> version, or that I've somehow not actually been updating rtld in my
> test VM. rtld is normally installed with the system-immutable (schg)
> flag, so there is some plausible explanation. As far as you're aware,
> after r288107 we've always had a zeroed GOT on rela?

I think so.

>
> Anyhow I think it doesn't much matter: if there's no ABI requirement
> for the GOT to be populated on rela architectures then it's a bug for
> FreeBSD's rtld to rely on that. I've posted a FreeBSD review to
> address that in rtld: https://reviews.freebsd.org/D9180.

Thanks!

Cheers,
Rafael

P.S.: I am currently debugging the next failure in the libreoffice
build. Looks like the problem is actually on firebird.