[PATCH] D28351: AMDGPU: Remove spurious out branches after a kill

Samuel Pitoiset via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 02:23:26 PST 2017

hakzsam added inline comments.

Comment at: test/CodeGen/AMDGPU/insert-skips-kill-uncond.mir:17-19
+# CHECK-NEXT: S_CBRANCH_EXECNZ %bb.2, implicit %exec
+# CHECK-LABEL: bb.3:
hakzsam wrote:
> nhaehnle wrote:
> > It would be good to check that there is no spurious branch /after/ the conditional branch either. This probably works:
> > 
> >   CHECK-NEXT: bb.3:
> > 
> Yes, I will fix that.
Actually, CHECK-NEXT: bb.3: doesn't work, but we could do CHECK-NEXT: EXP_DONE instead, because the skip block is added just after.


More information about the llvm-commits mailing list