[PATCH] D28639: [NDS32 2/22] Add NDS32 ELF defines

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 00:28:02 PST 2017


davide added a comment.

In https://reviews.llvm.org/D28639#647020, @shiva0217 wrote:

> In https://reviews.llvm.org/D28639#645151, @joerg wrote:
>
> > Test cases?
>
>
> Hi joerg,
>  Did you mean add the test case like test/MC/NDS32/elf-reloc.s in https://reviews.llvm.org/D28659 ?
>  If so, should I move the test case to this patch ?
>  I reference https://reviews.llvm.org/D23558 and it didn't add testcases when adding ELF defines.
>  Could you help me to point out the right test I should add ? 
>  Thanks.


To remove the dependency on llvm-mc you can probably just check-in a small binary.


https://reviews.llvm.org/D28639





More information about the llvm-commits mailing list