[PATCH] D28707: PDB: Add a class to create the /names stream contents.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 14 16:45:15 PST 2017


ruiu added inline comments.


================
Comment at: llvm/lib/DebugInfo/PDB/Raw/NameHashTableBuilder.cpp:96
+
+  if (auto EC = Writer.writeArray(ArrayRef<ulittle32_t>(Buckets)))
+    return EC;
----------------
zturner wrote:
> Is the conversion to `ArrayRef` necessary?  It should get converted implicitly I think.
Seems like I need to convert to `ArrayRef` since `writeArray` is a overloaded function.


https://reviews.llvm.org/D28707





More information about the llvm-commits mailing list