[PATCH] D28731: [PATCH] Fix warning about parentheses in boolean expression.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 14 10:16:42 PST 2017


davide requested changes to this revision.
davide added a reviewer: davide.
davide added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:1080-1088
+    (
+      !isa<Instruction>(NewClass->RepLeader) ||
+      !NewClass->RepLeader ||
       I == NewClass->RepLeader ||
-      (!DT->properlyDominates(
-          I->getParent(),
-          cast<Instruction>(NewClass->RepLeader)->getParent()) &&
-          "New class for instruction should not be dominated by instruction"));
+      !DT->properlyDominates(
+        I->getParent(),
+        cast<Instruction>(NewClass->RepLeader)->getParent())
----------------
This needs to be clang-formatt'ed


Repository:
  rL LLVM

https://reviews.llvm.org/D28731





More information about the llvm-commits mailing list