[PATCH] D28731: [PATCH] Fix warning about parentheses in boolean expression.

[Gonsolo via Phabricator via llvm-commits]

gonsolo updated this revision to Diff 84453.
gonsolo added a comment.

Better?


https://reviews.llvm.org/D28731

Files:
  lib/Transforms/Scalar/NewGVN.cpp


Index: lib/Transforms/Scalar/NewGVN.cpp
===================================================================
--- lib/Transforms/Scalar/NewGVN.cpp
+++ lib/Transforms/Scalar/NewGVN.cpp
@@ -1077,12 +1077,15 @@
   // instruction.  We simply check that the member instruction does not properly
   // dominate the new class leader.
   assert(
-      !isa<Instruction>(NewClass->RepLeader) || !NewClass->RepLeader ||
+    (
+      !isa<Instruction>(NewClass->RepLeader) ||
+      !NewClass->RepLeader ||
       I == NewClass->RepLeader ||
-      (!DT->properlyDominates(
-          I->getParent(),
-          cast<Instruction>(NewClass->RepLeader)->getParent()) &&
-          "New class for instruction should not be dominated by instruction"));
+      !DT->properlyDominates(
+        I->getParent(),
+        cast<Instruction>(NewClass->RepLeader)->getParent())
+    ) &&
+    "New class for instruction should not be dominated by instruction");
 
   if (NewClass->RepLeader != I) {
     auto DFSNum = InstrDFS.lookup(I);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28731.84453.patch
Type: text/x-patch
Size: 1016 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170114/83d882ef/attachment.bin>