[llvm] r292003 - Removing potentially error-prone fallthrough. NFC

Marcello Maggioni via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 23:28:47 PST 2017


Author: mggm
Date: Sat Jan 14 01:28:47 2017
New Revision: 292003

URL: http://llvm.org/viewvc/llvm-project?rev=292003&view=rev
Log:
Removing potentially error-prone fallthrough. NFC

This fallthrough if other cases are added between fabs and default
could cause fabs to fall to the next case resulting in a bug.
Better getting rid of it immediately just to be sure.

Modified:
    llvm/trunk/lib/Analysis/InstructionSimplify.cpp

Modified: llvm/trunk/lib/Analysis/InstructionSimplify.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/InstructionSimplify.cpp?rev=292003&r1=292002&r2=292003&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/InstructionSimplify.cpp (original)
+++ llvm/trunk/lib/Analysis/InstructionSimplify.cpp Sat Jan 14 01:28:47 2017
@@ -4267,6 +4267,7 @@ static Value *SimplifyIntrinsic(Function
     case Intrinsic::fabs: {
       if (SignBitMustBeZero(*ArgBegin, Q.TLI))
         return *ArgBegin;
+      return nullptr;
     }
     default:
       return nullptr;




More information about the llvm-commits mailing list