[PATCH] D28726: Adding const overloads of operator* and operator-> for DenseSet iterators

Hugo Puhlmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 23:36:17 PST 2017


hstefan updated this revision to Diff 84436.
hstefan added a comment.

Now both classes have overloads for operator-> and operator* in a uniform way.


https://reviews.llvm.org/D28726

Files:
  include/llvm/ADT/DenseSet.h


Index: include/llvm/ADT/DenseSet.h
===================================================================
--- include/llvm/ADT/DenseSet.h
+++ include/llvm/ADT/DenseSet.h
@@ -104,7 +104,9 @@
     Iterator(const typename MapTy::iterator &i) : I(i) {}
 
     ValueT &operator*() { return I->getFirst(); }
+    const ValueT &operator*() const { return I->getFirst(); }
     ValueT *operator->() { return &I->getFirst(); }
+    const ValueT *operator->() const { return &I->getFirst(); }
 
     Iterator& operator++() { ++I; return *this; }
     Iterator operator++(int) { auto T = *this; ++I; return T; }
@@ -125,8 +127,8 @@
 
     ConstIterator(const typename MapTy::const_iterator &i) : I(i) {}
 
-    const ValueT &operator*() { return I->getFirst(); }
-    const ValueT *operator->() { return &I->getFirst(); }
+    const ValueT &operator*() const { return I->getFirst(); }
+    const ValueT *operator->() const { return &I->getFirst(); }
 
     ConstIterator& operator++() { ++I; return *this; }
     ConstIterator operator++(int) { auto T = *this; ++I; return T; }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28726.84436.patch
Type: text/x-patch
Size: 1064 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170114/7ba0be7a/attachment.bin>


More information about the llvm-commits mailing list