[PATCH] D28508: [NVPTX] Lower to sqrt.approx and rsqrt.approx under more circumstances.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 17:36:22 PST 2017


hfinkel added a comment.

In https://reviews.llvm.org/D28508#644774, @jlebar wrote:

> > The patch only does this transformation with fastmath enabled (or if you pass a special flag to llvm that specifically asks for this transformation):
>
> Hal, maybe this was your point of confusion as well, and if so, I'm sorry about that.  Really bad commit message on my part.


No, I understood that -- I only really care about sqrt and friends when fast-math is enabled. Otherwise the performance is horrible essentially everywhere. ;)


https://reviews.llvm.org/D28508





More information about the llvm-commits mailing list