[PATCH] D28700: [NVPTX] Let there be One True Way to set NVVMReflect params.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 15:29:15 PST 2017


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/NVPTX/nvvm-reflect.ll:4-6
+; RUN: echo '!0 = !{i32 4, !"nvvm-reflect-ftz", i32 0}' > %t
+; RUN: cat %s %t | opt - -S -nvvm-reflect -O2 \
+; RUN:   | FileCheck %s --check-prefix=USE_FTZ_0 --check-prefix=CHECK
----------------
Nit. Could we construct whole input in one file instead of piping two separate files through?
```
cp %s %t
echo '!0...' >> %t
opt %t... | FileCheck
```
This would make it a bit more convenient to manually rerun these commands if necessary.


https://reviews.llvm.org/D28700





More information about the llvm-commits mailing list