[PATCH] D28708: Compute summary before calling extractProfTotalWeight

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 15:28:26 PST 2017


davidxl accepted this revision.
davidxl added a comment.

lgtm



================
Comment at: unittests/Analysis/ProfileSummaryInfoTest.cpp:101
+TEST_F(ProfileSummaryInfoTest, TestNoProfile) {
+  auto M = makeLLVMModule();
+  Function *F = M->getFunction("f");
----------------
It is slightly more readable to do:

const char *ProfKind = nullptr;
auto M = makeLLVMModule(ProfKind);


https://reviews.llvm.org/D28708





More information about the llvm-commits mailing list