[PATCH] D28578: [GlobalISel] correctly record PHI sources coming from switch instructions

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/IRTranslator.h:405
+  /// represented simply by the IR-level CFG.
+  void addMachineCFGPred(CFGEdge Edge, MachineBasicBlock *NewPred);
+
----------------
qcolombet wrote:
> const CFGEdge &, MachineBasicBlock &
I did think about this at the time, but decided a pair of pointers was simple enough to pass by value. I can change it, but I'm not convinced there's a strong argument either way.


Repository:
  rL LLVM

https://reviews.llvm.org/D28578