[PATCH] D27038: [XRay][compiler-rt] XRay Flight Data Recorder Mode

Serge Rogatch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 11:17:41 PST 2017


rSerge added inline comments.


================
Comment at: include/xray/xray_log_interface.h:23-27
+  XRAY_LOG_UNINITIALIZED,
+  XRAY_LOG_INITIALIZING,
+  XRAY_LOG_INITIALIZED,
+  XRAY_LOG_FINALIZING,
+  XRAY_LOG_FINALIZED,
----------------
Still, for debugging purpose I think it would be more convenient to have the numeric values along enum member names... say in debug I see "3" - I would have to count from the beginning of the enum to determine whether it's `XRAY_LOG_FINALIZING` or `XRAY_LOG_FINALIZED`.


https://reviews.llvm.org/D27038





More information about the llvm-commits mailing list