[PATCH] D28574: [scudo] Refactor of CRC32 and ARM runtime CRC32 detection

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/scudo/scudo_allocator.cpp:87
+    return computeHardwareCRC32(Crc, Data);
+  return computeSoftwareCRC32(Crc, Data);
+#endif  // defined(__SSE4_2__)
----------------
nit pick, an extra else adds clarity and helps future changes.


================
Comment at: lib/scudo/scudo_utils.cpp:105
+bool testCPUFeature(CPUFeature Feature) {
+  static uptr HWCap = getauxval(AT_HWCAP);
+
----------------
This only works on Linux, right?


https://reviews.llvm.org/D28574