[PATCH] D28635: [libFuzzer] Portably disassemble and find calls to "sanitizer_cov_trace_pc_guard".

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: lib/Fuzzer/FuzzerTracePC.cpp:162
+      size_t PcOffsetEnd = S.find(':');
+      if (PcOffsetEnd == std::string::npos) continue;
+      S.resize(PcOffsetEnd);
----------------
Can you put the `continue` on a new line?


================
Comment at: lib/Fuzzer/FuzzerUtilWindows.cpp:181
+std::string DisassembleCmd(const std::string &FileName) {
+  return "dumpbin /disasm " + FileName;
+}
----------------
`dumpbin` is not guaranteed to be in the user's path.  Is this going to cause a problem?  Also I believe `dumpbin` will use Intel syntax for the disassembly.  Does objdump use AT&T syntax by default?  If so, will this cause a problem?


Repository:
  rL LLVM

https://reviews.llvm.org/D28635